Share XContent rendering code in terms aggs #23680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
:Analytics/Aggregations
javanna
force-pushed
the
enhancement/terms_aggs_fromxcontext
branch
from
873c5ef to
3c43b32
Compare
tlrx
approved these changes
Mar 22, 2017
| return builder; | ||
| } | ||
|
|
||
| protected abstract XContentBuilder doXContentKey(XContentBuilder builder) throws IOException; |
There was a problem hiding this comment.
Nit: we named such methods "innerToXContent()" at some other places, worth to reuse the same name?
There was a problem hiding this comment.
I'd like to keep key in the name, I find innerToXContent very generic , how about keyToXContent ?
There was a problem hiding this comment.
My comment was more about name coherency than pure naming. I'm fine with both doXContentKey or keyToXContent with a preference for the later.
The output of the different implementations of terms aggs is always very similar. The toXContent methods for each of those classes though was duplicating almost the same code multiple times. This commit centralizes the code for rendering XContent to a single place, which can be reused from the different terms aggs implementations.
javanna
force-pushed
the
enhancement/terms_aggs_fromxcontext
branch
from
3c43b32 to
4457aff
Compare
javanna
added a commit
that referenced
this pull request
Mar 22, 2017
The output of the different implementations of terms aggs is always very similar. The toXContent methods for each of those classes though was duplicating almost the same code multiple times. This commit centralizes the code for rendering XContent to a single place, which can be reused from the different terms aggs implementations.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2017
* master: [API] change wait_for_completion defaults according to docs (elastic#23672) Share XContent rendering code in terms aggs (elastic#23680) Update ingest-node.asciidoc [DOCS] Update the docs about the fact that global ordinals for _parent field are loaded eagerly instead of lazily by default. Build: remove progress logger hack for gradle 2.13 (elastic#23679) Test: Add dump of integ test cluster logs on failure (elastic#23688) Plugins: Add plugin cli specific exit codes (elastic#23599) Plugins: Output better error message when existing plugin is incompatible (elastic#23562) Reindex: wait for cleanup before responding (elastic#23677) Packaging: Remove classpath ordering hack (elastic#23596) Docs: Add note about updating plugins requiring removal and reinstallation (elastic#23597) Build: Make plugin list for smoke tester dynamic (elastic#23601) [TEST] Propertly cleans up failing restore test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of the different implementations of terms aggs is always very similar. The
toXContentmethods for each of those classes though was duplicating almost the same code multiple times. This commit centralizes the code for renderingXContentto a single place, which can be reused from the different terms aggs implementations.